Open
Conversation
Not sure why there's no option to output iXML to stdout as well as a .xml file, so I've crudely added it for my own purposes.
Member
|
This is too direct, and specific:
IMO there is the need of some refactoring for having a common function for writing to files then an option should be used for knowing if we need to save in a file or export to cout or both. I get it that this is a lot more code to change... |
Author
|
Agreed, making it consistent and optional would be best - but unfortunately beyond my own expertise. Perhaps someone else will come along and take a look in the future, or I'll return to it when my C++ skills improve :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed iXML output to stdout as well as an .xml file, so I added a cout just before the file is saved. There may be a more elegant way to do it, in which case I'd be glad to hear about it!